| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1360877226-12014-1-git-send-email-peterhuewe@gmx.de> Date: Thu, 14 Feb 2013 22:27:06 +0100 From: Peter Huewe <peterhuewe@....de> To: Ian Abbott <abbotti@....co.uk> Cc: Mori Hess <fmhess@...rs.sourceforge.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, H Hartley Sweeten <hsweeten@...ionengravers.com>, Bill Pemberton <wfp5p@...ginia.edu>, Peter Huewe <peterhuewe@....de>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH] staging/comedi: Use && instead of & for logical comparision sparse complains that: drivers/staging/comedi/drivers/adl_pci9118.c:813 pci9118_calc_divisors() warn: maybe use && instead of & usessh is used as a boolean flag (0 and 1) and is compared to a boolean value so we should use && here. Signed-off-by: Peter Huewe <peterhuewe@....de> --- drivers/staging/comedi/drivers/adl_pci9118.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/adl_pci9118.c b/drivers/staging/comedi/drivers/adl_pci9118.c index ef4dbe5..4dbac74 100644 --- a/drivers/staging/comedi/drivers/adl_pci9118.c +++ b/drivers/staging/comedi/drivers/adl_pci9118.c @@ -810,7 +810,7 @@ static void pci9118_calc_divisors(char mode, struct comedi_device *dev, *tim2 = *div1 * devpriv->i8254_osc_base; /* real convert timer */ - if (usessh & (chnsshfront == 0)) /* use BSSH signal */ + if (usessh && (chnsshfront == 0)) /* use BSSH signal */ if (*div2 < (chans + 2)) *div2 = chans + 2; -- 1.7.8.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists