linux-kernel - Re: [PATCH 5/9] ARM: shmobile: mark mackerel sh_mmcif_device __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130214232426.GB30667@verge.net.au>
Date:	Fri, 15 Feb 2013 08:24:26 +0900
From:	Simon Horman <horms@...ge.net.au>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	Guennadi Liakhovetski <g.liakhovetski@....de>,
	Simon Horman <horms+renesas@...ge.net.au>
Subject: Re: [PATCH 5/9] ARM: shmobile: mark mackerel sh_mmcif_device
 __maybe_unused

On Thu, Feb 14, 2013 at 11:26:54PM +0100, Arnd Bergmann wrote:
> Patch eac036ef9e "ARM: shmobile: streamline mackerel SD and MMC devices"
> made the use of the sh_mmcif_device variable for mackarel optional,
> but the definition is always provided, causing a build warning.
> 
> arch/arm/mach-shmobile/board-mackerel.c:1120:31: warning: 'sh_mmcif_device'
> 	defined but not used [-Wunused-variable]
> 
> Marking the variable as __maybe_unused will do the right thing here.
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> Cc: Guennadi Liakhovetski <g.liakhovetski@....de>
> Cc: Simon Horman <horms+renesas@...ge.net.au>

No objections here.

Acked-by: Simon Horman <horms+renesas@...ge.net.au>

> ---
>  arch/arm/mach-shmobile/board-mackerel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/mach-shmobile/board-mackerel.c b/arch/arm/mach-shmobile/board-mackerel.c
> index 0c78207..1de898f 100644
> --- a/arch/arm/mach-shmobile/board-mackerel.c
> +++ b/arch/arm/mach-shmobile/board-mackerel.c
> @@ -1117,7 +1117,7 @@ static struct sh_mmcif_plat_data sh_mmcif_plat = {
>  	.slave_id_rx	= SHDMA_SLAVE_MMCIF_RX,
>  };
>  
> -static struct platform_device sh_mmcif_device = {
> +static struct platform_device sh_mmcif_device __maybe_unused = {
>  	.name		= "sh_mmcif",
>  	.id		= 0,
>  	.dev		= {
> -- 
> 1.8.1.2
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/