linux-kernel - Re: [PATCH 03/11] rtc: rtc-efi: use pr_err()/pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Date:	Fri, 15 Feb 2013 06:37:49 +0000 (GMT)
From:	Jingoo Han <jg1.han@...sung.com>
To:	Venu Byravarasu <vbyravarasu@...dia.com>,
	'Andrew Morton' <akpm@...ux-foundation.org>
Cc:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	"rtc-linux@...glegroups.com" <rtc-linux@...glegroups.com>,
	Jingoo Han <jg1.han@...sung.com>
Subject: Re: [PATCH 03/11] rtc: rtc-efi: use pr_err()/pr_warn() instead of
 printk()

On Friday, February 15, 2013 3:04 PM, Venu Byravarasu wrote:
> 
> > -----Original Message-----
> > From: linux-kernel-owner@...r.kernel.org [mailto:linux-kernel-
> > owner@...r.kernel.org] On Behalf Of Jingoo Han
> > Sent: Friday, February 15, 2013 11:29 AM
> > To: 'Andrew Morton'
> > Cc: linux-kernel@...r.kernel.org; 'Alessandro Zummo'; rtc-
> > linux@...glegroups.com; 'Jingoo Han'
> > Subject: [PATCH 03/11] rtc: rtc-efi: use pr_err()/pr_warn() instead of printk()
> >
> > Fixed the checkpatch warnings as below:
> >
> >   WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...
> > to printk(KERN_ERR ...
> >   WARNING: please, no space before tabs
> >
> > Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> > ---
> >  drivers/rtc/rtc-efi.c |   10 ++++++----
> >  1 files changed, 6 insertions(+), 4 deletions(-)
> >
> >  	eft->timezone	= EFI_UNSPECIFIED_TIMEZONE;
> > @@ -142,7 +144,7 @@ static int efi_set_alarm(struct device *dev, struct
> > rtc_wkalrm *wkalrm)
> >  	 */
> >  	status = efi.set_wakeup_time((efi_bool_t)wkalrm->enabled, &eft);
> >
> > -	printk(KERN_WARNING "write status is %d\n", (int)status);
> > +	pr_warn("write status is %d\n", (int)status);
> 
> Why don't you use dev_warn itself?

OK, I will change it.
Thank you.

Best regards,
Jingoo Han

> 
> >
> >  	return status == EFI_SUCCESS ? 0 : -EINVAL;
> >  }
> > @@ -157,7 +159,7 @@ static int efi_read_time(struct device *dev, struct
> > rtc_time *tm)
> >
> >  	if (status != EFI_SUCCESS) {
> >  		/* should never happen */
> > -		printk(KERN_ERR "efitime: can't read time\n");
> > +		pr_err("can't read time\n");
> 
> Why don't you use dev_err itself?
> 
> >  		return -EINVAL;
> >  	}
> >
> > --
> > 1.7.2.5
> >
> >
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> > the body of a message to majordomo@...r.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> > Please read the FAQ at  http://www.tux.org/lkml/