linux-kernel - Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1360910978.2089.3.camel@joe-AO722>
Date:	Thu, 14 Feb 2013 22:49:38 -0800
From:	Joe Perches <joe@...ches.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Andrew Morton' <akpm@...ux-foundation.org>,
	linux-kernel@...r.kernel.org,
	'Alessandro Zummo' <a.zummo@...ertech.it>,
	rtc-linux@...glegroups.com
Subject: Re: [PATCH V2 07/11] rtc: rtc-rs5c313: use pr_err() instead of
 printk()

On Fri, 2013-02-15 at 15:46 +0900, Jingoo Han wrote:
> Fixed the checkpatch warning as below:
[]
> diff --git a/drivers/rtc/rtc-rs5c313.c b/drivers/rtc/rtc-rs5c313.c
[]
> @@ -39,6 +39,8 @@
>   *	1.13	Nobuhiro Iwamatsu: Updata driver.
>   */
>  
> +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
> +
>  #include <linux/module.h>
>  #include <linux/err.h>
>  #include <linux/rtc.h>
> @@ -352,8 +354,7 @@ static void rs5c313_check_xstp_bit(void)
>  		tm.tm_year 	= 2000 - 1900;
>  
>  		rs5c313_rtc_set_time(NULL, &tm);
> -		printk(KERN_ERR "RICHO RS5C313: invalid value, resetting to "
> -				"1 Jan 2000\n");
> +		pr_err("RICHO RS5C313: invalid value, resetting to 1 Jan 2000\n");

You could remove the "RICH0 RS5C313: "prefix,
pr_fmt adds it (more or less).


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/