linux-kernel - Re: [PATCH 1/7] staging/ozwpan: Fix sparse warning Using plain integer as NULL pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130215084517.GB6802@mwanda>
Date:	Fri, 15 Feb 2013 11:45:17 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Rupesh Gujare <rupesh.gujare@...el.com>,
	devel@...verdev.osuosl.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/7] staging/ozwpan: Fix sparse warning Using plain
 integer as NULL pointer

On Fri, Feb 15, 2013 at 06:25:29AM +0100, Peter Huewe wrote:
> This patch fixes the warning "Using plain integer as NULL pointer",
> generated by sparse, by replacing the offending 0s with NULL.
> 
> Signed-off-by: Peter Huewe <peterhuewe@....de>

Don't send 7 patches with the same subject.

> @@ -455,7 +455,7 @@ int oz_prepare_frame(struct oz_pd *pd, int empty)
>   */
>  static struct sk_buff *oz_build_frame(struct oz_pd *pd, struct oz_tx_frame *f)
>  {
> -	struct sk_buff *skb = 0;
> +	struct sk_buff *skb = NULL;

This initialization could just be removed.

>  	struct net_device *dev = pd->net_dev;
>  	struct oz_hdr *oz_hdr;
>  	struct oz_elt *elt;
> @@ -464,8 +464,8 @@ static struct sk_buff *oz_build_frame(struct oz_pd *pd, struct oz_tx_frame *f)
>  	 * as the space we need.
>  	 */
>  	skb = alloc_skb(f->total_size + OZ_ALLOCATED_SPACE(dev), GFP_ATOMIC);
> -	if (skb == 0)
> -		return 0;
> +	if (skb == NULL)
> +		return NULL;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/