linux-kernel - Re: [PATCH] staging/panel: Mark local functions as static (fix smatch warnings)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <12246.1360925745@warthog.procyon.org.uk>
Date:	Fri, 15 Feb 2013 10:55:45 +0000
From:	David Howells <dhowells@...hat.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	dhowells@...hat.com, Willy Tarreau <willy@...a-x.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Toshiaki Yamane <yamanetoshi@...il.com>,
	Adam Buchbinder <adam.buchbinder@...il.com>,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] staging/panel: Mark local functions as static (fix smatch warnings)

Peter Huewe <peterhuewe@....de> wrote:

> +static char old_keypad_profile[][4][9] = {
>  	{"S0", "Left\n", "Left\n", ""},
>  	{"S1", "Down\n", "Down\n", ""},
>  	{"S2", "Up\n", "Up\n", ""},

Things like this should likely be const also.  There are several here.

> -void panel_lcd_print(char *s)
> +static void panel_lcd_print(char *s)

const char *s maybe?

David
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/