| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Fri, 15 Feb 2013 13:14:26 +0100 From: Peter Huewe <peterhuewe@....de> To: Ian Abbott <abbotti@....co.uk> Cc: Mori Hess <fmhess@...rs.sourceforge.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, H Hartley Sweeten <hsweeten@...ionengravers.com>, Bill Pemberton <wfp5p@...ginia.edu>, Peter Huewe <peterhuewe@....de>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org Subject: [PATCH v2] staging/comedi: Remove if(); statement without effect Smatch warns about: staging/comedi/drivers/cb_pcidas64.c:3304 prep_ao_dma() warn: if(); So the check currently does nothing and can be removed, as indicated by Ian. Signed-off-by: Peter Huewe <peterhuewe@....de> --- v1 was staging/comedi: Fix if(); by adding proper code which was unfortunately wrong. drivers/staging/comedi/drivers/cb_pcidas64.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/staging/comedi/drivers/cb_pcidas64.c b/drivers/staging/comedi/drivers/cb_pcidas64.c index d33fc32..9f3112c 100644 --- a/drivers/staging/comedi/drivers/cb_pcidas64.c +++ b/drivers/staging/comedi/drivers/cb_pcidas64.c @@ -3301,7 +3301,6 @@ static int prep_ao_dma(struct comedi_device *dev, const struct comedi_cmd *cmd) num_bytes = load_ao_dma_buffer(dev, cmd); if (num_bytes == 0) return -1; - if (num_bytes >= DMA_BUFFER_SIZE) ; load_ao_dma(dev, cmd); dma_start_sync(dev, 0); -- 1.7.8.6 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists