linux-kernel - Re: [PATCH 2/2] block: account iowait time when waiting for completion of IO request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130215154421.GA6131@kernel.dk>
Date:	Fri, 15 Feb 2013 16:44:21 +0100
From:	Jens Axboe <axboe@...nel.dk>
To:	Vladimir Davydov <vdavydov@...allels.com>
Cc:	Ingo Molnar <mingo@...hat.com>,
	Peter Zijlstra <peterz@...radead.org>, devel@...nvz.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] block: account iowait time when waiting for
 completion of IO request

On Thu, Feb 14 2013, Vladimir Davydov wrote:
> Using wait_for_completion() for waiting for a IO request to be executed
> results in wrong iowait time accounting. For example, a system having
> the only task doing write() and fdatasync() on a block device can be
> reported being idle instead of iowaiting as it should because
> blkdev_issue_flush() calls wait_for_completion() which in turn calls
> schedule() that does not increment the iowait proc counter and thus does
> not turn on iowait time accounting.
> 
> The patch makes block layer use wait_for_completion_io() instead of
> wait_for_completion() where appropriate to account iowait time
> correctly.

Thanks, applied both for 3.9 (with Ingos ack).

-- 
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/