linux-kernel - Re: [PATCH] futex: avoid kernel taint caused by get_robust

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGXu5jL3DQis5aETSAWJ8AC43s8tmMEXZ-bNwWLdJ6p_4fP=Yw@mail.gmail.com>
Date:	Fri, 15 Feb 2013 08:41:27 -0800
From:	Kees Cook <keescook@...omium.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	LKML <linux-kernel@...r.kernel.org>, Dave Jones <davej@...hat.com>,
	Richard Weinberger <richard@....at>,
	Thomas Gleixner <tglx@...utronix.de>,
	Paul Gortmaker <paul.gortmaker@...driver.com>
Subject: Re: [PATCH] futex: avoid kernel taint caused by get_robust_list

Hi Andrew,

Is this revert something you would be willing to take?

-Kees

On Fri, Feb 15, 2013 at 8:32 AM, Paul Gortmaker
<paul.gortmaker@...driver.com> wrote:
> On 13-02-15 11:18 AM, Kees Cook wrote:
>> On Fri, Feb 15, 2013 at 7:54 AM, Paul Gortmaker
>> <paul.gortmaker@...driver.com> wrote:
>>> commit ec0c4274e33c0373e476b73e01995c53128f1257 ("futex: Mark
>>> get_robust_list as deprecated") added these two WARN_ONCE calls.
>>>
>>> However, WARN_ONCE taints the kernel, and we shouldn't be allowing
>>> any user who wanders by to do this.  For example, the system fuzzer
>>> "trinity" uses the tainted state as a metric for when to stop,
>>> assuming that it has caused significant wreckage (and indeed
>>> that tool is what actually led me to this change).
>>>
>>> The ability to deprecate this code has been called into question[1],
>>> but if that remains to be finalized, then making this change in the
>>> interim seems to make sense.
>>>
>>> [1] http://lkml.indiana.edu/hypermail/linux/kernel/1208.0/01081.html
>>>
>>> Cc: Dave Jones <davej@...hat.com>
>>> Cc: Richard Weinberger <richard@....at>
>>> Cc: Kees Cook <keescook@...omium.org>
>>> Cc: Thomas Gleixner <tglx@...utronix.de>
>>> Cc: stable@...r.kernel.org      # 3.4+
>>> Signed-off-by: Paul Gortmaker <paul.gortmaker@...driver.com>
>>
>> I Acked the original revert. I thought there was agreement that it was
>> needed for checkpointing to work?
>
> There were several acks in the original thread, but for some unknown
> reason (at least unknown to me and Richard), it never made it in tree...

-- 
Kees Cook
Chrome OS Security
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/