linux-kernel - Re: [PATCH] ia64: rename cache_show to topology_cache

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20130215144629.be18bae9.akpm@linux-foundation.org>
Date:	Fri, 15 Feb 2013 14:46:29 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Michal Hocko <mhocko@...e.cz>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Wu Fengguang <fengguang.wu@...el.com>,
	Glauber Costa <glommer@...allels.com>,
	Tony Luck <tony.luck@...el.com>,
	Fenghua Yu <fenghua.yu@...el.com>
Subject: Re: [PATCH] ia64: rename cache_show to topology_cache_show

On Fri, 15 Feb 2013 13:38:24 +0100
Michal Hocko <mhocko@...e.cz> wrote:

> Fenguang Wu has reported the following compile time issue
> arch/ia64/kernel/topology.c:278:16: error: conflicting types for 'cache_show'
> include/linux/slab.h:224:5: note: previous declaration of 'cache_show' was here
> 
> which has been introduced by 749c5415 (memcg: aggregate memcg cache
> values in slabinfo). Let's rename ia64 local function to prevent from
> the name conflict.

Confused.  Tony fixed this ages ago?

: commit 4fafc8c21487f6b5259d462e9bee98661a02390d
: Author: Tony Luck <tony.luck@...el.com>
: Date:   Wed Nov 7 15:51:04 2012 -0800
: 
:     [IA64] Resolve name space collision for cache_show()
:     
:     We have a local static function named rather generically
:     "cache_show()". Changes in progress in the slab code want
:     to use this same name globally - so they are adding their
:     declaration to <linux/slab.h> which then causes the compiler
:     to choke with:
:     
:     arch/ia64/kernel/topology.c:278: error: conflicting types for 'cache_show'
:     
:     Fix by adding an "ia64_" prefix to our local function.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/