linux-kernel - Re: [RESEND] [PATCH] kernel/res_counter.c: remove useless return statement at res_counter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <511F5F04.9000009@oracle.com>
Date:	Sat, 16 Feb 2013 18:27:16 +0800
From:	Jeff Liu <jeff.liu@...cle.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	LKML <linux-kernel@...r.kernel.org>,
	David Rientjes <rientjes@...gle.com>
Subject: Re: [RESEND] [PATCH] kernel/res_counter.c: remove useless return
 statement at res_counter_member()

Hi Andrew and David,

On 02/15/2013 07:21 AM, Andrew Morton wrote:
> On Sat, 02 Feb 2013 13:04:52 +0800
> Jeff Liu <jeff.liu@...cle.com> wrote:
> 
>> The return statement after BUG() is invalid, move BUG() to the default choice of the switch.
>>
>> Signed-off-by: Jie Liu <jeff.liu@...cle.com>
>> ---
>>  kernel/res_counter.c |    5 ++---
>>  1 file changed, 2 insertions(+), 3 deletions(-)
>>
>> diff --git a/kernel/res_counter.c b/kernel/res_counter.c
>> index ff55247..748a3bc 100644
>> --- a/kernel/res_counter.c
>> +++ b/kernel/res_counter.c
>> @@ -135,10 +135,9 @@ res_counter_member(struct res_counter *counter, int member)
>>  		return &counter->failcnt;
>>  	case RES_SOFT_LIMIT:
>>  		return &counter->soft_limit;
>> +	default:
>> +		BUG();
>>  	};
>> -
>> -	BUG();
>> -	return NULL;
>>  }
>>  
>>  ssize_t res_counter_read(struct res_counter *counter, int member,
> 
> I expect it was done that way to avoid a hey-theres-no-return-statement
> warning when CONFIG_BUG=n.
> 
Sorry for my late response, I just got back from vacation.  So it's better to
keep it as it is.

Thanks,
-Jeff

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/