| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Sat, 16 Feb 2013 17:44:09 +0530 From: anish kumar <anish198519851985@...il.com> To: akpm@...ux-foundation.org, dzickus@...hat.com, mingo@...nel.org Cc: chuansheng.liu@...el.com, paulmck@...ux.vnet.ibm.com, linux-kernel@...r.kernel.org, anish kumar <anish198519851985@...il.com> Subject: [PATCH] [Watchdog][Trivial] Added comments to explain watchdog_disabled variable From: anish kumar <anish198519851985@...il.com> This watchdog_disabled flag is bit of cryptic.Howerver it's usefullnes is multifold. Uses are: 1. Check if smpboot_register_percpu_thread function passed. 2. Makes sure that user enables and disables the watchdog in sequence i.e. enable watchdog->disable watchdog->enable watchdog Unlike enable watchdog->enable watchdog which is wrong. Signed-off-by: anish kumar <anish198519851985@...il.com> --- kernel/watchdog.c | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/kernel/watchdog.c b/kernel/watchdog.c index 75a2ab3..8a20ebe 100644 --- a/kernel/watchdog.c +++ b/kernel/watchdog.c @@ -518,6 +518,11 @@ int proc_dowatchdog(struct ctl_table *table, int write, return ret; set_sample_period(); + /* + * Watchdog threads shouldn't be enabled if they are + * disabled.'watchdog_disabled' variable check in + * watchdog_*_all_cpus() function takes care of this. + */ if (watchdog_enabled && watchdog_thresh) watchdog_enable_all_cpus(); else -- 1.7.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists