linux-kernel - Re: [PATCH 2/2] power: rx51_battery: Fix reporting correct values

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130216213937.GE1741@lizard.sbx05280.losalca.wayport.net>
Date:	Sat, 16 Feb 2013 13:39:40 -0800
From:	Anton Vorontsov <anton@...msg.org>
To:	Pali Rohár <pali.rohar@...il.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] power: rx51_battery: Fix reporting correct values

On Fri, Feb 15, 2013 at 11:56:50PM +0100, Pali Rohár wrote:
> Tell twl4030_madc_conversion that this driver needs raw values.
> Driver twl4030_madc has some hardcoded values and conversation
> functions which are incorrect for Nokia RX-51 board. This driver
> rx51_battery expects raw values which convert itself.
> 
> This patch fixing values reported by power supply interface.
> Before this patch driver reported always incorrect values on
> 3.8 kernel (sometimes design capacity was negative).
> 
> Signed-off-by: Pali Rohár <pali.rohar@...il.com>

Assuming you want to pass the series via MFD tree,

Acked-by: Anton Vorontsov <anton@...msg.org>

Thanks!

> ---
>  drivers/power/rx51_battery.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/power/rx51_battery.c b/drivers/power/rx51_battery.c
> index 527d256..d1e17b0 100644
> --- a/drivers/power/rx51_battery.c
> +++ b/drivers/power/rx51_battery.c
> @@ -42,6 +42,7 @@ static int rx51_battery_read_adc(int channel)
>  	req.method = TWL4030_MADC_SW1;
>  	req.func_cb = NULL;
>  	req.type = TWL4030_MADC_WAIT;
> +	req.raw = true;
>  
>  	if (twl4030_madc_conversion(&req) <= 0)
>  		return -ENODATA;
> -- 
> 1.7.10.4
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/