linux-kernel - Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAPnjgZ2Kn12EMD1+hr5xRhcjbh77qiYj--5-LcqCzwp3t7wdHw@mail.gmail.com>
Date:	Fri, 15 Feb 2013 19:58:30 -0800
From:	Simon Glass <sjg@...omium.org>
To:	Joe Perches <joe@...ches.com>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Samuel Ortiz <sameo@...ux.intel.com>,
	Che-Liang Chiou <clchiou@...omium.org>,
	Jonathan Kliegman <kliegs@...omium.org>,
	Luigi Semenzato <semenzato@...omium.org>,
	Olof Johansson <olofj@...omium.org>,
	Vincent Palatin <vpalatin@...omium.org>,
	Grant Likely <grant.likely@...retlab.ca>,
	Rob Herring <rob.herring@...xeda.com>,
	Rob Landley <rob@...dley.net>,
	devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH v2 2/6] mfd: Add ChromeOS EC implementation

Hi Joe,

On Tue, Feb 12, 2013 at 7:35 PM, Joe Perches <joe@...ches.com> wrote:
> On Tue, 2013-02-12 at 18:42 -0800, Simon Glass wrote:
>> This is the base EC implementation, which provides a high level
>> interface to the EC for use by the rest of the kernel. The actual
>> communcations is dealt with by a separate protocol driver which
>> registers itself with this interface.
>
> trivial logging message comments...

Thanks - I will tidy these up in the next spin.

>
>> diff --git a/drivers/mfd/cros_ec.c b/drivers/mfd/cros_ec.c
> []
>> +struct cros_ec_device *cros_ec_alloc(const char *name)
>> +{
>> +     struct cros_ec_device *ec_dev;
>> +
>> +     ec_dev = kzalloc(sizeof(*ec_dev), GFP_KERNEL);
>> +     if (ec_dev == NULL) {
>> +             dev_err(ec_dev->dev, "cannot allocate\n");
>
> allocation OOM messages aren't useful as there's
> a standard one on all allocs without __GFP_WARN
>
>> +int cros_ec_register(struct cros_ec_device *ec_dev)
>> +{
> []
>> +             ec_dev->din = kmalloc(ec_dev->din_size, GFP_KERNEL);
>> +             if (!ec_dev->din) {
>> +                     err = -ENOMEM;
>> +                     dev_err(dev, "cannot allocate din\n");
>
> etc...
>
>> +     if (err) {
>> +             dev_err(dev, "failed to add mfd devices");
>
> missing terminating newline
>
>

Regards,
Simon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/