linux-kernel - Re: [RFC] SIGKILL vs. SIGSEGV on late execve() failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+55aFyzGenPNnKxf_PnAWVa1tZP294XUrhAVXgi0EuKm1x=vA@mail.gmail.com>
Date:	Fri, 15 Feb 2013 16:40:18 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Al Viro <viro@...iv.linux.org.uk>
Cc:	Shentino <shentino@...il.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [RFC] SIGKILL vs. SIGSEGV on late execve() failures

On Fri, Feb 15, 2013 at 4:04 PM, Al Viro <viro@...iv.linux.org.uk> wrote:
> On Fri, Feb 15, 2013 at 03:12:30PM -0800, Shentino wrote:
>> > +                               send_sig(SIGSEGV, current, 0);
>>
>> This might be a stupid miscue on my part, but shouldn't it be
>> force_sig instead of send_sig?
>>
>> I've got this crazy hunch that having SEGV masked might muck something up.
>
> How would you manage to have it masked at that point?  setup_new_exec()
> is inevitable after success of flush_old_exec() and it will do
> flush_signal_handlers() for us.

I have to agree with Shentino on this one: it's entirely possible that
send_sig() is always equivalent to force_sig() in this circumstance,
but rather than depend on that kind of non-local subtlety, we should
just make it obvious. This is what "force_sig()" exists for - making
it clear that we punch through any signal handlers. Whether such a
signal handler can exist or not is kind of immaterial.

               Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/