linux-kernel - Re: [PATCH] sound: usb/quirks, fix out-of-bounds access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <s5hy5emc1r1.wl%tiwai@suse.de>
Date:	Sun, 17 Feb 2013 18:02:26 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	perex@...ex.cz, jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Damien Zammit <damien@...audio.com>
Subject: Re: [PATCH] sound: usb/quirks, fix out-of-bounds access

At Sun, 17 Feb 2013 14:33:04 +0100,
Jiri Slaby wrote:
> 
> bootresponse in snd_usb_mbox2_boot_quirk is only 12 (decimal) u8's
> long, but i9s passed to snd_usb_ctl_msg as it would be 0x12 (hexa)
> long. Fix that by having proper size of the array, i.e. 0x12.
> 
> Signed-off-by: Jiri Slaby <jslaby@...e.cz>
> Cc: Damien Zammit <damien@...audio.com>
> Cc: Takashi Iwai <tiwai@...e.de>

A good catch.  Applied now.  Thanks!


Takashi

> ---
>  sound/usb/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 2c97185..0115289 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -533,7 +533,7 @@ static int snd_usb_mbox2_boot_quirk(struct usb_device *dev)
>  {
>  	struct usb_host_config *config = dev->actconfig;
>  	int err;
> -	u8 bootresponse[12];
> +	u8 bootresponse[0x12];
>  	int fwsize;
>  	int count;
>  
> -- 
> 1.8.1.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/