linux-kernel - Re: [PATCH v2 1/3] mfd: syscon: Removed support for unloading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 17 Feb 2013 10:42:57 +0800
From:	Dong Aisheng <dong.aisheng@...aro.org>
To:	Alexander Shiyan <shc_work@...l.ru>
Cc:	linux-kernel@...r.kernel.org, Samuel Ortiz <sameo@...ux.intel.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	Arnd Bergmann <arnd@...db.de>
Subject: Re: [PATCH v2 1/3] mfd: syscon: Removed support for unloading

On 12 February 2013 02:42, Alexander Shiyan <shc_work@...l.ru> wrote:
> The driver can be used in various subsystems and therefore should not
> be unloaded when it is defined in the kernel configuration, so remove
> support for unloading it.
>
> Signed-off-by: Alexander Shiyan <shc_work@...l.ru>

Acked-by: Dong Aisheng <dong.aisheng@...aro.org>

Regards
Dong Aisheng

> ---
>  drivers/mfd/syscon.c | 18 ------------------
>  1 file changed, 18 deletions(-)
>
> diff --git a/drivers/mfd/syscon.c b/drivers/mfd/syscon.c
> index 3f10591..e1886fb 100644
> --- a/drivers/mfd/syscon.c
> +++ b/drivers/mfd/syscon.c
> @@ -138,17 +138,6 @@ static int syscon_probe(struct platform_device *pdev)
>         return 0;
>  }
>
> -static int syscon_remove(struct platform_device *pdev)
> -{
> -       struct syscon *syscon;
> -
> -       syscon = platform_get_drvdata(pdev);
> -       iounmap(syscon->base);
> -       platform_set_drvdata(pdev, NULL);
> -
> -       return 0;
> -}
> -
>  static struct platform_driver syscon_driver = {
>         .driver = {
>                 .name = "syscon",
> @@ -156,7 +145,6 @@ static struct platform_driver syscon_driver = {
>                 .of_match_table = of_syscon_match,
>         },
>         .probe          = syscon_probe,
> -       .remove         = syscon_remove,
>  };
>
>  static int __init syscon_init(void)
> @@ -165,12 +153,6 @@ static int __init syscon_init(void)
>  }
>  postcore_initcall(syscon_init);
>
> -static void __exit syscon_exit(void)
> -{
> -       platform_driver_unregister(&syscon_driver);
> -}
> -module_exit(syscon_exit);
> -
>  MODULE_AUTHOR("Dong Aisheng <dong.aisheng@...aro.org>");
>  MODULE_DESCRIPTION("System Control driver");
>  MODULE_LICENSE("GPL v2");
> --
> 1.7.12.4
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/