linux-kernel - [PATCH] pci: do not try to assign irq 255

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1361182193-31894-1-git-send-email-hare@suse.de>
Date:	Mon, 18 Feb 2013 11:09:53 +0100
From:	Hannes Reinecke <hare@...e.de>
To:	linux-kernel@...r.kernel.org
Cc:	Hannes Reinecke <hare@...e.de>, Frederik Himpe <fhimpe@....ac.be>,
	Oliver Neukum <oneukum@...e.de>,
	David Haerdeman <david@...deman.nu>, linux-usb@...r.kernel.org,
	linux-pci@...r.kernel.org
Subject: [PATCH] pci: do not try to assign irq 255

The PCI config space reseves a byte for the interrupt line,
so irq 255 actually refers to 'not set'.
However, the 'irq' field for struct pci_dev is an integer,
so the original meaning is lost, causing the system to
assign an interrupt '255', which fails.

So we should _not_ assign an interrupt value here, and
allow upper layers to fixup things.

This patch make PCI devices with MSI interrupts only
(like the xhci device on certain HP laptops) work properly.

Cc: Frederik Himpe <fhimpe@....ac.be>
Cc: Oliver Neukum <oneukum@...e.de>
Cc: David Haerdeman <david@...deman.nu>
Cc: linux-usb@...r.kernel.org
Cc: linux-pci@...r.kernel.org
Signed-off-by: Hannes Reinecke <hare@...e.de>

diff --git a/drivers/pci/probe.c b/drivers/pci/probe.c
index 6186f03..a2db887f 100644
--- a/drivers/pci/probe.c
+++ b/drivers/pci/probe.c
@@ -923,7 +923,8 @@ static void pci_read_irq(struct pci_dev *dev)
 	dev->pin = irq;
 	if (irq)
 		pci_read_config_byte(dev, PCI_INTERRUPT_LINE, &irq);
-	dev->irq = irq;
+	if (irq < 255)
+		dev->irq = irq;
 }
 
 void set_pcie_port_type(struct pci_dev *pdev)
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/