linux-kernel - Re: [PATCH v6 4/7] fat: restructure export

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fw0t3mq0.fsf@devron.myhome.or.jp>
Date:	Mon, 18 Feb 2013 20:06:31 +0900
From:	OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
To:	Namjae Jeon <linkinjeon@...il.com>
Cc:	akpm@...ux-foundation.org, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Namjae Jeon <namjae.jeon@...sung.com>,
	Ravishankar N <ravi.n1@...sung.com>,
	Amit Sahrawat <a.sahrawat@...sung.com>
Subject: Re: [PATCH v6 4/7] fat: restructure export_operations

Namjae Jeon <linkinjeon@...il.com> writes:

> +	if (MSDOS_SB(inode->i_sb)->options.nfs == FAT_NFS_NOSTALE_RO) {
> +		if (inode->i_ino == MSDOS_ROOT_INO)
> +			stat->ino = MSDOS_ROOT_INO;

Can we simply set i_pos = MSDOS_ROOT_INO in fat_read_root()? If so, I
think we can avoid this check.

> +		else
> +			/* Use i_pos for ino. This is used as fileid of nfs. */
> +			stat->ino = fat_i_pos_read(MSDOS_SB(inode->i_sb),
> +						   inode);
> +	}
>  	return 0;
>  }
>  EXPORT_SYMBOL_GPL(fat_getattr);


> +struct fat_fid {
> +	u32 i_gen;
> +	u32 i_pos_low;
> +	u16 i_pos_hi;
> +	u16 parent_i_pos_hi;
> +	u32 parent_i_pos_low;
> +	u32 parent_i_gen;
> +} __packed;

Do we need to use __packed? Unnecessary __packed can generate slower
code for alignment check on arch has unaligned fault.

> +	if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) {
> +		*lenp = FAT_FID_SIZE_WITH_PARENT;
> +		return 255;
> +	} else if (len < FAT_FID_SIZE_WITHOUT_PARENT) {
> +		*lenp = FAT_FID_SIZE_WITHOUT_PARENT;
> +		return 255;
> +	}

This check strange. "parent && len == FAT_FID_SIZE_WITHOUT_PARENT" will
overwrite over limit of fh size?
-- 
OGAWA Hirofumi <hirofumi@...l.parknet.co.jp>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/