linux-kernel - Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130218111217.GL20771@intel.com>
Date:	Mon, 18 Feb 2013 13:12:17 +0200
From:	Mika Westerberg <mika.westerberg@...ux.intel.com>
To:	Alexander Holler <holler@...oftware.de>
Cc:	linux-kernel@...r.kernel.org, Jiri Kosina <jkosina@...e.cz>,
	Benjamin Tissoires <benjamin.tissoires@...il.com>,
	linux-input@...r.kernel.org, srinivas.pandruvada@...el.com
Subject: Re: [PATCH 3/3] HID: sensor-hub: don't limit the driver only to USB
 bus

On Mon, Feb 18, 2013 at 12:03:04PM +0100, Alexander Holler wrote:
> Am 11.02.2013 11:31, schrieb Mika Westerberg:
> >We now have two transport mediums: USB and I2C, where sensor hubs can
> >exists. So instead of constraining the driver to only these two we let it
> >to match any HID bus as long as the group is HID_GROUP_SENSOR_HUB.
> >
> >Signed-off-by: Mika Westerberg <mika.westerberg@...ux.intel.com>
> >---
> >  drivers/hid/hid-sensor-hub.c |    3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> >diff --git a/drivers/hid/hid-sensor-hub.c b/drivers/hid/hid-sensor-hub.c
> >index 2643bce9..c01f10d 100644
> >--- a/drivers/hid/hid-sensor-hub.c
> >+++ b/drivers/hid/hid-sensor-hub.c
> >@@ -603,7 +603,8 @@ static void sensor_hub_remove(struct hid_device *hdev)
> >  }
> >
> >  static const struct hid_device_id sensor_hub_devices[] = {
> >-	{ HID_DEVICE(BUS_USB, HID_GROUP_SENSOR_HUB, HID_ANY_ID, HID_ANY_ID) },
> >+	{ HID_DEVICE(HID_BUS_ANY, HID_GROUP_SENSOR_HUB, HID_ANY_ID,
> >+		     HID_ANY_ID) },
> >  	{ }
> >  };
> >  MODULE_DEVICE_TABLE(hid, sensor_hub_devices);
> >
> 
> Hmm, what happens with Bluetooth sensor-hubs? Is the driver now able
> to handle them too?

It should, yes.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/