linux-kernel - Re: [PATCH 3/5] staging/xgifb: Remove code without effect

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130218112507.GF6802@mwanda>
Date:	Mon, 18 Feb 2013 14:25:07 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Peter Huewe <peterhuewe@....de>
Cc:	Arnaud Patard <arnaud.patard@...-net.org>,
	devel@...verdev.osuosl.org, Aaro Koskinen <aaro.koskinen@....fi>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/5] staging/xgifb: Remove code without effect

On Fri, Feb 15, 2013 at 08:37:11PM +0100, Peter Huewe wrote:
> The tempal variable is assigned and then immediately overwritten.
> -> remove everything without effect.
> 
> The inb is kept for possible side effects.
> 

This was dead code after we removed old mode <= 14 support in
34c13ee2b "staging: xgifb: drop code for legacy VGA modes".

I don't know if the inb() is still needed.  Aaro?

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/