lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2013 21:20:10 +0200
From: Felipe Balbi <balbi@...com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: Felipe Balbi <balbi@...com>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [BONUS PATCH 2/2] base: core: WARN() about bogus permissions on
device attributes
On Mon, Feb 18, 2013 at 11:17:19AM -0800, Greg KH wrote:
> On Mon, Feb 18, 2013 at 09:09:04PM +0200, Felipe Balbi wrote:
> > Whenever a struct device_attribute is registered
> > with mismatched permissions - read permission without
> > a show routine or write permission without store
> > routine - we will issue a big warning so we catch
> > those early enough.
> >
> > Signed-off-by: Felipe Balbi <balbi@...com>
> > ---
> >
> > This is completely untested. I have only compile tested
> > to make sure I'm not breaking anything.
> >
> > Greg, do you think this would be nice to have ? I could
> > fire up kvm tomorrow and run on a few of my OMAP-based
> > boards to make sure it works as expected.
>
> Looks good, but you better fix up all of the big offenders that this
> points out, before I apply it, otherwise we will get a ton of bug
> reports :)
sure, will do that tomorrow though ;-)
--
balbi
Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)
Powered by blists - more mailing lists