linux-kernel - Re: [PATCH v3 1/1] tools/power x86_energy_perf

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 18 Feb 2013 00:06:17 -0500
From:	Len Brown <lenb@...nel.org>
To:	Benson Leung <bleung@...omium.org>
CC:	colin.king@...onical.com, linux-kernel@...r.kernel.org,
	vapier@...too.org
Subject: Re: [PATCH v3 1/1] tools/power x86_energy_perf_policy: fix cpuid
 for i686

Hi Benson,

checkpatch.pl doesn't love this syntax:

ERROR: spaces required around that ':' (ctx:ExV)
#113: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:142:
+		      :"+a" (_eax), "=S" (_ebx), "=c" (_ecx), "=d" (_edx)
 		      ^

ERROR: spaces required around that ':' (ctx:ExV)
#115: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:144:
+		      :"edi" /* clobbers: we hit edi directly */);
 		      ^

ERROR: trailing statements should be on next line
#116: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:145:
+	if (eax) *eax = _eax;

ERROR: trailing statements should be on next line
#117: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:146:
+	if (ebx) *ebx = _ebx;

ERROR: trailing statements should be on next line
#118: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:147:
+	if (ecx) *ecx = _ecx;

ERROR: trailing statements should be on next line
#119: FILE: tools/power/x86/x86_energy_perf_policy/x86_energy_perf_policy.c:148:
+	if (edx) *edx = _edx;

total: 6 errors, 2 warnings, 57 lines checked

/home/lenb/Documents/epp.eml has style problems, please review.

If any of these errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
Commit Body is:
--------------------------
tools/power x86_energy_perf_policy: fix cpuid for i686

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/