lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Mon, 18 Feb 2013 23:20:43 -0800 From: Joe Perches <joe@...ches.com> To: Simon Glass <sjg@...omium.org> Cc: Dmitry Torokhov <dmitry.torokhov@...il.com>, LKML <linux-kernel@...r.kernel.org>, Samuel Ortiz <sameo@...ux.intel.com>, Luigi Semenzato <semenzato@...omium.org>, Vincent Palatin <vpalatin@...omium.org>, Grant Likely <grant.likely@...retlab.ca>, Rob Herring <rob.herring@...xeda.com>, Rob Landley <rob@...dley.net>, Felipe Balbi <balbi@...com>, Sourav Poddar <sourav.poddar@...com>, Tony Lindgren <tony@...mide.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, "Mike A. Chan" <mikechan@...gle.com>, Jun Nakajima <jun.nakajima@...el.com>, Tom Keel <thomas.keel@...el.com>, devicetree-discuss@...ts.ozlabs.org, linux-doc@...r.kernel.org, linux-input@...r.kernel.org Subject: Re: [PATCH v4 6/6] Input: Add ChromeOS EC keyboard driver On Mon, 2013-02-18 at 20:13 -0800, Simon Glass wrote: > On Sat, Feb 16, 2013 at 12:49 PM, Dmitry Torokhov > > On Fri, Feb 15, 2013 at 08:16:12PM -0800, Simon Glass wrote: > >> + for (row = 0; row < ckdev->rows; row++) { > >> + if (cros_ec_keyb_row_has_ghosting(ckdev, buf, row)) > >> + return true; > >> + } > > > > No need for curly braces here. I would not care if not for below. > > OK I dont't think I even knew about that rule. Actually, what is that rule? There is no rule, uses with and without braces exist in about similar numbers in the kernel. Both are used ~2000 times. Newer uses more commonly have braces and I think using braces is a better style. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists