linux-kernel - Re: [patch 1/2] kcmp: Make it to depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130219093154.GF20312@moon>
Date:	Tue, 19 Feb 2013 13:31:54 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Michal Marek <mmarek@...e.cz>
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	ebiederm@...ssion.com, xemul@...allels.com, hpa@...or.com,
	akpm@...ux-foundation.org, Andrey Vagin <avagin@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Andi Kleen <andi@...stfloor.org>, Tejun Heo <tj@...nel.org>,
	Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

On Tue, Feb 19, 2013 at 10:22:21AM +0100, Michal Marek wrote:
> On 19.2.2013 07:48, Cyrill Gorcunov wrote:
> > --- linux-2.6.git.orig/init/Kconfig
> > +++ linux-2.6.git/init/Kconfig
> > @@ -279,6 +279,15 @@ config FHANDLE
> >  	  get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2)
> >  	  syscalls.
> >  
> > +config KCMP
> > +	bool "kcmp syscall"
> > +	default n
> 
> Previously, kcmp was enabled with CONFIG_CHECKPOINT_RESTORE. Maybe
> change it to 'default CHECKPOINT_RESTORE', so that make oldconfig does
> the right thing?

Yes, thanks, good point! I've been adviced that make it obj-y by default
may be a good option as well, not sure.
---
From: Cyrill Gorcunov <gorcunov@...nvz.org>
Subject: kcmp: Make it to depend on CONFIG_KCMP

Since kcmp syscall has been implemented (initially on
x86 architecture) a number of other archs wire it up
as well: xtensa, sparc, sh, s390, mips, microblaze,
m68k (not taking into account those who uses
<asm-generic/unistd.h> for syscall numbers
definitions).

But the Makefile, which turns kcmp.o generation on
still depends on former config-x86. Thus get rid
of this limitation and make kcmp.o depend on CONFIG_KCMP
option.

v2:
 - As Michal pointed the old configs might already use of
   CHECKPOINT_RESTORE, so make "default" accordingly.

Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@...il.com>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Pavel Emelyanov <xemul@...allels.com>
Cc: Andrey Vagin <avagin@...nvz.org>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Glauber Costa <glommer@...allels.com>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Tejun Heo <tj@...nel.org>
Cc: Matt Helsley <matthltc@...ibm.com>
Cc: Pekka Enberg <penberg@...nel.org>
Cc: Eric Dumazet <eric.dumazet@...il.com>
Cc: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Alexey Dobriyan <adobriyan@...il.com>
Cc: Valdis.Kletnieks@...edu
Cc: Michal Marek <mmarek@...e.cz>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
 init/Kconfig    |    9 +++++++++
 kernel/Makefile |    4 +---
 2 files changed, 10 insertions(+), 3 deletions(-)

Index: linux-2.6.git/init/Kconfig
===================================================================
--- linux-2.6.git.orig/init/Kconfig
+++ linux-2.6.git/init/Kconfig
@@ -279,6 +279,15 @@ config FHANDLE
 	  get renamed. Enables open_by_handle_at(2) and name_to_handle_at(2)
 	  syscalls.
 
+config KCMP
+	bool "kcmp syscall"
+	default CHECKPOINT_RESTORE
+	help
+	  If you say Y here, a user level program will be able to use
+	  kcmp(2) syscall.
+
+	  If unsure, say N.
+
 config AUDIT
 	bool "Auditing support"
 	depends on NET
Index: linux-2.6.git/kernel/Makefile
===================================================================
--- linux-2.6.git.orig/kernel/Makefile
+++ linux-2.6.git/kernel/Makefile
@@ -25,9 +25,7 @@ endif
 obj-y += sched/
 obj-y += power/
 
-ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
-obj-$(CONFIG_X86) += kcmp.o
-endif
+obj-$(CONFIG_KCMP) += kcmp.o
 obj-$(CONFIG_FREEZER) += freezer.o
 obj-$(CONFIG_PROFILING) += profile.o
 obj-$(CONFIG_STACKTRACE) += stacktrace.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/