linux-kernel - Re: [PATCH] dma: timb_dma: Fix compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <512363CC.7000401@metafoo.de>
Date:	Tue, 19 Feb 2013 12:36:44 +0100
From:	Lars-Peter Clausen <lars@...afoo.de>
To:	maxin.john@...il.com
CC:	djbw@...com, vinod.koul@...el.com, geert@...ux-m68k.org,
	linux-kernel@...r.kernel.org, "Maxin B. John" <maxin.john@...a.com>
Subject: Re: [PATCH] dma: timb_dma: Fix compiler warning

On 02/18/2013 08:59 PM, maxin.john@...il.com wrote:
> From: "Maxin B. John" <maxin.john@...a.com>
> 
> Fix this compiler warning:
> warning: 'td_remove' defined but not used [-Wunused-function]
>
> Signed-off-by: Maxin B. John <maxin.john@...a.com>
> ---
>  drivers/dma/timb_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/dma/timb_dma.c b/drivers/dma/timb_dma.c
> index 952f823..f709279 100644
> --- a/drivers/dma/timb_dma.c
> +++ b/drivers/dma/timb_dma.c
> @@ -798,7 +798,7 @@ err_release_region:
>  
>  }
>  
> -static int td_remove(struct platform_device *pdev)
> +static int __exit td_remove(struct platform_device *pdev)
>  {

>

While this fixes the warning, it's the wrong fix. The correct fix is to
remove the __exit_p. E.g. something like this:

--- a/drivers/dma/timb_dma.c
+++ b/drivers/dma/timb_dma.c
@@ -823,7 +823,7 @@ static struct platform_driver td_driver = {
 		.owner  = THIS_MODULE,
 	},
 	.probe	= td_probe,
-	.remove	= __exit_p(td_remove),
+	.remove	= td_remove,
 };

 module_platform_driver(td_driver);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/