linux-kernel - Re: [PATCH] mfd: wm8994: add missing variable initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130219121801.GB23508@opensource.wolfsonmicro.com>
Date:	Tue, 19 Feb 2013 12:18:01 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Jingoo Han <jg1.han@...sung.com>
Cc:	'Samuel Ortiz' <sameo@...ux.intel.com>,
	patches@...nsource.wolfsonmicro.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: wm8994: add missing variable initialization

On Tue, Feb 19, 2013 at 09:56:26AM +0900, Jingoo Han wrote:

> -	int ret, i, patch_regs;
> +	int ret, i, patch_regs = 0;

As with all such changes you really need to explain why it's safe to
just blindly initialise to this particular value and why this isn't just
masking a real issue in the code.  Initialising with a random value will
fix the warning but that might just be turning off the compiler's
checks.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)