linux-kernel - Re: [patch 1/1] early_printk: Consolidate random copies of identical code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130219130334.GA11137@gmail.com>
Date:	Tue, 19 Feb 2013 14:03:34 +0100
From:	Ingo Molnar <mingo@...nel.org>
To:	Thomas Gleixner <tglx@...utronix.de>
Cc:	LKML <linux-kernel@...r.kernel.org>,
	Russell King <linux@....linux.org.uk>,
	Mike Frysinger <vapier@...too.org>,
	Michal Simek <monstr@...str.eu>,
	Ralf Baechle <ralf@...ux-mips.org>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Paul Mundt <lethal@...ux-sh.org>,
	"David S. Miller" <davem@...emloft.net>,
	Chris Metcalf <cmetcalf@...era.com>,
	Richard Weinberger <richard@....at>, x86@...nel.org
Subject: Re: [patch 1/1] early_printk: Consolidate random copies of identical
 code


* Thomas Gleixner <tglx@...utronix.de> wrote:

> The early console implementations are the same all over the
> place. Move the print function to kernel/printk and get rid of the
> copies.
> 
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Russell King <linux@....linux.org.uk>
> Cc: Mike Frysinger <vapier@...too.org>
> Cc: Michal Simek <monstr@...str.eu>
> Cc: Ralf Baechle <ralf@...ux-mips.org>
> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Cc: Paul Mundt <lethal@...ux-sh.org>
> Cc: "David S. Miller" <davem@...emloft.net>
> Cc: Chris Metcalf <cmetcalf@...era.com>
> Cc: Richard Weinberger <richard@....at>
> Cc: x86@...nel.org
> 
> ---
>  arch/arm/kernel/early_printk.c        |   17 +++--------------
>  arch/blackfin/kernel/early_printk.c   |    2 --
>  arch/microblaze/kernel/early_printk.c |   26 ++++----------------------
>  arch/mips/kernel/early_printk.c       |   11 +++++------
>  arch/powerpc/kernel/udbg.c            |    6 ++----
>  arch/sh/kernel/sh_bios.c              |    2 --
>  arch/sparc/kernel/setup_32.c          |    1 +
>  arch/sparc/kernel/setup_64.c          |    8 +++++++-
>  arch/tile/kernel/early_printk.c       |   27 +++++----------------------
>  arch/um/kernel/early_printk.c         |    8 +++++---
>  arch/unicore32/kernel/early_printk.c  |   12 ++++--------
>  arch/x86/kernel/early_printk.c        |   21 ++-------------------
>  include/linux/console.h               |    1 +
>  include/linux/printk.h                |    6 ++++++
>  kernel/printk.c                       |   30 +++++++++++++++++++++++-------
>  15 files changed, 68 insertions(+), 110 deletions(-)

Reviewed-by: Ingo Molnar <mingo@...nel.org>

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/