linux-kernel - Re: [PATCH] mfd:adp5520: Restore mode bits on resume

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 14:10:04 +0100
From:	Michael Hennerich <michael.hennerich@...log.com>
To:	Lars-Peter Clausen <lars@...afoo.de>
CC:	Samuel Ortiz <sameo@...ux.intel.com>,
	"device-drivers-devel@...ckfin.uclinux.org" 
	<device-drivers-devel@...ckfin.uclinux.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mfd:adp5520: Restore mode bits on resume

On 02/19/2013 11:51 AM, Lars-Peter Clausen wrote:
> The adp5520 unfortunately also clears the BL_EN bit when the nSTNDBY bit is
> cleared. So we need to make sure to restore it during resume if it was set
> before suspend.
>
> Cc: stable@...r.kernel.org
> Signed-off-by: Lars-Peter Clausen <lars@...afoo.de>
Acked-by: Michael Hennerich <michael.hennerich@...log.com>
> ---
>   drivers/mfd/adp5520.c | 8 ++++++--
>   1 file changed, 6 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
> index 210dd03..6b40e0c 100644
> --- a/drivers/mfd/adp5520.c
> +++ b/drivers/mfd/adp5520.c
> @@ -36,6 +36,7 @@ struct adp5520_chip {
>   	struct blocking_notifier_head notifier_list;
>   	int irq;
>   	unsigned long id;
> +	uint8_t mode;
>   };
>   
>   static int __adp5520_read(struct i2c_client *client,
> @@ -326,7 +327,10 @@ static int adp5520_suspend(struct device *dev)
>   	struct i2c_client *client = to_i2c_client(dev);
>   	struct adp5520_chip *chip = dev_get_drvdata(&client->dev);
>   
> -	adp5520_clr_bits(chip->dev, ADP5520_MODE_STATUS, ADP5520_nSTNBY);
> +	adp5520_read(chip->dev, ADP5520_MODE_STATUS, &chip->mode);
> +	/* All other bits are W1C */
> +	chip->mode &= ADP5520_BL_EN | ADP5520_DIM_EN | ADP5520_nSTNBY;
> +	adp5520_write(chip->dev, ADP5520_MODE_STATUS, 0);
>   	return 0;
>   }
>   
> @@ -335,7 +339,7 @@ static int adp5520_resume(struct device *dev)
>   	struct i2c_client *client = to_i2c_client(dev);
>   	struct adp5520_chip *chip = dev_get_drvdata(&client->dev);
>   
> -	adp5520_set_bits(chip->dev, ADP5520_MODE_STATUS, ADP5520_nSTNBY);
> +	adp5520_write(chip->dev, ADP5520_MODE_STATUS, chip->mode);
>   	return 0;
>   }
>   #endif


-- 
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/