linux-kernel - Re: [Bug fix PATCH 1/2] acpi, movablemem_map: Do not zero numa_meminfo in numa

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 21:16:39 +0800
From:	Tang Chen <tangchen@...fujitsu.com>
To:	akpm@...ux-foundation.org, jiang.liu@...wei.com,
	wujianguo@...wei.com, hpa@...or.com, wency@...fujitsu.com,
	laijs@...fujitsu.com, linfeng@...fujitsu.com, yinghai@...nel.org,
	isimatu.yasuaki@...fujitsu.com, rob@...dley.net,
	kosaki.motohiro@...fujitsu.com, minchan.kim@...il.com,
	mgorman@...e.de, rientjes@...gle.com, guz.fnst@...fujitsu.com,
	rusty@...tcorp.com.au, lliubbo@...il.com, jaegeuk.hanse@...il.com,
	tony.luck@...el.com, glommer@...allels.com,
	Shaohua Li <shli@...nel.org>
CC:	linux-kernel@...r.kernel.org, linux-mm@...ck.org
Subject: Re: [Bug fix PATCH 1/2] acpi, movablemem_map: Do not zero numa_meminfo
 in numa_init().

Sorry, add cc Li Shaohua.

Reported-by: Li Shaohua <shli@...nel.org>


On 02/19/2013 09:01 PM, Tang Chen wrote:
> early_parse_srat() is called before numa_init(), and has initialized
> numa_meminfo. So do not zero numa_meminfo in numa_init(), otherwise
> we will lose memory numa info.
>
> Signed-off-by: Tang Chen<tangchen@...fujitsu.com>
> ---
>   arch/x86/mm/numa.c |    6 ++++--
>   1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/arch/x86/mm/numa.c b/arch/x86/mm/numa.c
> index 3545585..ff3633c 100644
> --- a/arch/x86/mm/numa.c
> +++ b/arch/x86/mm/numa.c
> @@ -559,10 +559,12 @@ static int __init numa_init(int (*init_func)(void))
>   	for (i = 0; i<  MAX_LOCAL_APIC; i++)
>   		set_apicid_to_node(i, NUMA_NO_NODE);
>
> -	/* Do not clear numa_nodes_parsed because SRAT was parsed earlier. */
> +	/*
> +	 * Do not clear numa_nodes_parsed or zero numa_meminfo here, because
> +	 * SRAT was parsed earlier in early_parse_srat().
> +	 */
>   	nodes_clear(node_possible_map);
>   	nodes_clear(node_online_map);
> -	memset(&numa_meminfo, 0, sizeof(numa_meminfo));
>   	WARN_ON(memblock_set_node(0, ULLONG_MAX, MAX_NUMNODES));
>   	numa_reset_distance();
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/