linux-kernel - Re: [PATCH] NET: ath5k, check ath5k_eeprom_mode_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 14:36:07 +0100
From:	Jiri Slaby <jslaby@...e.cz>
To:	Nick Kossifidis <mickflemm@...il.com>,
	Jiri Slaby <jirislaby@...il.com>
CC:	linville@...driver.com, linux-wireless@...r.kernel.org,
	ath5k-devel@...ts.ath5k.org, linux-kernel@...r.kernel.org,
	"Luis R. Rodriguez" <mcgrof@....qualcomm.com>
Subject: Re: [PATCH] NET: ath5k, check ath5k_eeprom_mode_from_channel retval

On 02/18/2013 01:47 AM, Nick Kossifidis wrote:
> int
> ath5k_eeprom_mode_from_channel(struct ieee80211_channel *channel)
> {
>         switch (channel->hw_value) {
>         case AR5K_MODE_11A:
>                 return AR5K_EEPROM_MODE_11A;
>         case AR5K_MODE_11G:
>                 return AR5K_EEPROM_MODE_11G;
>         case AR5K_MODE_11B:
>                 return AR5K_EEPROM_MODE_11B;
>         default:
>                 return -1;
>         }
> }
> 
> I think we should just change that default to return 0 instead and add
> an ATH5K_WARN there.

Something like the attached patch? It needs ah to be propagated to
eeprom. If you are fine with that, I'll send it as patch...

thanks,
-- 
js
suse labs

View attachment "0001-ath5k-cleanup-channel-to-eprom_mode-function.patch" of type "text/x-patch" (4041 bytes)