linux-kernel - Re: SYSFS "errors"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Tue, 19 Feb 2013 16:53:24 +0200
From:	Felipe Balbi <balbi@...com>
To:	Mauro Carvalho Chehab <mchehab@...hat.com>
CC:	Borislav Petkov <bp@...en8.de>, Felipe Balbi <balbi@...com>,
	Greg KH <gregkh@...uxfoundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Ingo Molnar <mingo@...hat.com>, <JBottomley@...allels.com>,
	<linux-scsi@...r.kernel.org>, <davem@...emloft.net>,
	<netdev@...r.kernel.org>,
	Doug Thompson <dougthompson@...ssion.com>,
	<linux-edac@...r.kernel.org>, <rjw@...k.pl>,
	<linux-pm@...r.kernel.org>
Subject: Re: SYSFS "errors"

On Tue, Feb 19, 2013 at 11:35:21AM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 19 Feb 2013 14:50:56 +0100
> Borislav Petkov <bp@...en8.de> escreveu:
> 
> > On Tue, Feb 19, 2013 at 03:38:09PM +0200, Felipe Balbi wrote:
> > > because changing the permission will cause the same issue:
> > 
> > Actually, I take that back. Mauro's patch will already create the file
> > anyway:
> > 
> > 	if (mci->set_sdram_scrub_rate || mci->get_sdram_scrub_rate)
> > 
> > Adjusting the permissions is simply the last missing piece to this patch
> > to make the interface to userspace 100% coherent.
> 
> That's covers everything but Hannes arguments. I don't think that
> adding just one more device_create_file() on a driver that creates
> dozens (or hundreds) of sys nodes, depending on the number of DIMMS
> on the system would make it any worse.
> 
> Regards,
> Mauro
> 
> [PATCH EDAC] edac: only create sdram_scrub_rate where supported
> 
> Currently, sdram_scrub_rate sysfs node is created even if the device
> doesn't support get/set the scub rate. Change the logic to only
> create this device node when the operation is supported.
> 
> Reported-by: Felipe Balbi <balbi@...com>
> Signed-off-by: Mauro Carvalho Chehab <mchehab@...hat.com>

looks alright to me:

Reviewed-by: Felipe Balbi <balbi@...com>

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)