linux-kernel - Re: [PATCH] mfd: Make AB8500_CORE select POWER

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130219153024.GA4098@gmail.com>
Date:	Tue, 19 Feb 2013 15:30:24 +0000
From:	Lee Jones <lee.jones@...aro.org>
To:	Axel Lin <axel.lin@...ics.com>
Cc:	Samuel Ortiz <sameo@...ux.intel.com>,
	Jonas Aaberg <jonas.aberg@...ricsson.com>,
	Bengt JONSSON <bengt.g.jonsson@...ricsson.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: Make AB8500_CORE select POWER_SUPPLY to fix build
 error

On Tue, 19 Feb 2013, Axel Lin wrote:

> This patch fixes below build error when CONFIG_POWER_SUPPLY is not set.
> 
> drivers/built-in.o: In function `ab8500_power_off':
> drivers/mfd/ab8500-sysctrl.c:37: undefined reference to `power_supply_get_by_name'
> drivers/mfd/ab8500-sysctrl.c:53: undefined reference to `power_supply_get_by_name'
> make: *** [vmlinux] Error 1
> 
> Signed-off-by: Axel Lin <axel.lin@...ics.com>
> ---
>  drivers/mfd/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 671f5b1..c346941 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -858,6 +858,7 @@ config EZX_PCAP
>  config AB8500_CORE
>  	bool "ST-Ericsson AB8500 Mixed Signal Power Management chip"
>  	depends on GENERIC_HARDIRQS && ABX500_CORE && MFD_DB8500_PRCMU
> +	select POWER_SUPPLY
>  	select MFD_CORE
>  	select IRQ_DOMAIN
>  	help

I noticed and was going to fix this up myself - it's the right thing
to do.

Acked-by: Lee Jones <lee.jones@...aro.org>

-- 
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/