linux-kernel - Re: [PATCH] dma: tegra: assume CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5123B108.1010207@wwwdotorg.org>
Date:	Tue, 19 Feb 2013 10:06:16 -0700
From:	Stephen Warren <swarren@...dotorg.org>
To:	Vinod Koul <vinod.koul@...el.com>
CC:	Dan Williams <djbw@...com>, linux-tegra@...r.kernel.org,
	linux-kernel@...r.kernel.org, Stephen Warren <swarren@...dia.com>
Subject: Re: [PATCH] dma: tegra: assume CONFIG_OF

On 02/17/2013 08:07 AM, Vinod Koul wrote:
> On Fri, Feb 15, 2013 at 02:18:59PM -0800, Dan Williams wrote:
>> On Fri, Feb 15, 2013 at 1:53 PM, Stephen Warren <swarren@...dotorg.org> wrote:
>>> From: Stephen Warren <swarren@...dia.com>
>>>
>>> Tegra only supports, and always enables, device tree. Remove all ifdefs
>>> and runtime checks for DT support from the driver.
>>>
>>> Signed-off-by: Stephen Warren <swarren@...dia.com>
>>
>> Acked-by: Dan Williams <djbw@...com>
>>
>> ..adding Vinod.
>
> I think it should assume CONFIG_DMA_OF?

I'm not quite sure what you're saying. There are no ifdefs in the driver
related to CONFIG_DMA_OF, so there's no code (ifdefs) that could benefit
from (be removed due to) assuming that.

Do you mean this driver should be updated to support the generic DMA DT
bindings? Yes, that's true. However, a patch to do so would be
completely unrelated. We've been holding off doing such a conversion
until the dmaengine core support for CONFIG_DMA_OF is in the kernel, so
we can use it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/