linux-kernel - Re: [patch 1/2] kcmp: Make it to depend on CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2013 02:15:48 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	"H. Peter Anvin" <hpa@...or.com>, Michal Marek <mmarek@...e.cz>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	ebiederm@...ssion.com, xemul@...allels.com,
	Andrey Vagin <avagin@...nvz.org>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	Glauber Costa <glommer@...allels.com>,
	Andi Kleen <andi@...stfloor.org>, Tejun Heo <tj@...nel.org>,
	Matt Helsley <matthltc@...ibm.com>,
	Pekka Enberg <penberg@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>,
	Vasiliy Kulikov <segoon@...nwall.com>,
	Alexey Dobriyan <adobriyan@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>
Subject: Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP

On Wed, Feb 20, 2013 at 02:11:46AM +0400, Cyrill Gorcunov wrote:
> On Tue, Feb 19, 2013 at 02:00:35PM -0800, Andrew Morton wrote:
> > > 
> > > I think this syscall is usefull even without c/r stuff.
> > > That's why I made it with separate config option.
> > 
> > hm, OK.
> > 
> > But the patch also permits CONFIG_CHECKPOINT_RESTORE=y, CONFIG_KCMP=n
> > which surely isn't something which CRIU wants to support?
> 
> Hmm, yes from one pov this feature is useful for out-of-c/r user,
> from another pov -- we will have to ask users to turn on additional
> CONFIG entries (which i'm sure not set by default in wide range of distros).
> Thus it seems less paiful way is either make it obj-(CHECKPOINT_RESTORE)
> as you proposed, or obj-y by default. The last can't be undone, so I'll
> prepare the patch for obj-(CHECKPOINT_RESTORE) I think.

Here is update. Peter, does it look good for you too?
---
From: Cyrill Gorcunov <gorcunov@...nvz.org>
Subject: kcmp: Make it to depend on CHECKPOINT_RESTORE

Since kcmp syscall has been implemented (initially on x86
architecture) a number of other archs wire it up as well:
xtensa, sparc, sh, s390, mips, microblaze, m68k (not taking
into account those who uses <asm-generic/unistd.h> for syscall
numbers definitions).

But the Makefile, which turns kcmp.o generation on still
depends on former config-x86. Thus get rid of this
limitation and make kcmp.o depend on CHECKPOINT_RESTORE
option.

Signed-off-by: Cyrill Gorcunov <gorcunov@...nvz.org>
Cc: KOSAKI Motohiro <kosaki.motohiro@...il.com>
Cc: "Eric W. Biederman" <ebiederm@...ssion.com>
Cc: Pavel Emelyanov <xemul@...allels.com>
Cc: Andrey Vagin <avagin@...nvz.org>
Cc: Ingo Molnar <mingo@...e.hu>
Cc: H. Peter Anvin <hpa@...or.com>
Cc: Thomas Gleixner <tglx@...utronix.de>
Cc: Glauber Costa <glommer@...allels.com>
Cc: Andi Kleen <andi@...stfloor.org>
Cc: Tejun Heo <tj@...nel.org>
Cc: Matt Helsley <matthltc@...ibm.com>
Cc: Pekka Enberg <penberg@...nel.org>
Cc: Eric Dumazet <eric.dumazet@...il.com>
Cc: Vasiliy Kulikov <segoon@...nwall.com>
Cc: Alexey Dobriyan <adobriyan@...il.com>
Cc: Valdis.Kletnieks@...edu
Cc: Michal Marek <mmarek@...e.cz>
Cc: Frederic Weisbecker <fweisbec@...il.com>
Cc: Andrew Morton <akpm@...ux-foundation.org>
---
 kernel/Makefile |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Index: linux-2.6.git/kernel/Makefile
===================================================================
--- linux-2.6.git.orig/kernel/Makefile
+++ linux-2.6.git/kernel/Makefile
@@ -25,9 +25,7 @@ endif
 obj-y += sched/
 obj-y += power/
 
-ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
-obj-$(CONFIG_X86) += kcmp.o
-endif
+obj-$(CHECKPOINT_RESTORE) += kcmp.o
 obj-$(CONFIG_FREEZER) += freezer.o
 obj-$(CONFIG_PROFILING) += profile.o
 obj-$(CONFIG_STACKTRACE) += stacktrace.o
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/