linux-kernel - Re: [PATCH] freezer: configure user space process frozen along with kernel threads

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130220090507.GV20312@moon>
Date:	Wed, 20 Feb 2013 13:05:07 +0400
From:	Cyrill Gorcunov <gorcunov@...nvz.org>
To:	Li Fei <fei.li@...el.com>
Cc:	pavel@....cz, rjw@...k.pl, len.brown@...el.com, mingo@...hat.com,
	peterz@...radead.org, akpm@...ux-foundation.org,
	viro@...iv.linux.org.uk, ebiederm@...ssion.com,
	rientjes@...gle.com, linux-kernel@...r.kernel.org,
	linux-pm@...r.kernel.org, chuansheng.liu@...el.com,
	biao.wang@...el.com
Subject: Re: [PATCH] freezer: configure user space process frozen along with
 kernel threads

On Wed, Feb 20, 2013 at 10:15:25AM +0800, Li Fei wrote:
>  
> +#ifdef CONFIG_FREEZER
> +
> +static ssize_t freeze_late_read(struct file *file, char __user *buf,
> +					size_t count, loff_t *ppos)
> +{
> +	struct task_struct *task = get_proc_task(file->f_path.dentry->d_inode);
> +	char buffer[PROC_NUMBUF];
> +	int freeze_late;
> +	size_t len;
> +	if (!task)
> +		return -ESRCH;
> +	freeze_late = (task->flags & PF_FREEZER_LATE) ? 1 : 0;
> +	len = snprintf(buffer, sizeof(buffer), "%d\n", freeze_late);
> +	return simple_read_from_buffer(buf, count, ppos, buffer, len);
> +}

Don't you need put_task_struct() once you grabbed it?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/