lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-id: <000001ce0f57$8b237050$a16a50f0$%han@samsung.com>
Date:	Wed, 20 Feb 2013 19:46:31 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Jingoo Han' <jg1.han@...sung.com>,
	'Samuel Ortiz' <sameo@...ux.intel.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mfd: twl4030-madc: add __exit macro to remove

On Tuesday, February 19, 2013 10:08 AM, Jingoo Han wrote:
> 
> Fixed build warning as below:
> 
> drivers/mfd/twl4030-madc.c:788:12: warning: 'twl4030_madc_remove' defined but not used [-Wunused-
> function]
> 
> Signed-off-by: Jingoo Han <jg1.han@...sung.com>
> ---
>  drivers/mfd/twl4030-madc.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
> index 88ff9dc..86ba920 100644
> --- a/drivers/mfd/twl4030-madc.c
> +++ b/drivers/mfd/twl4030-madc.c
> @@ -785,7 +785,7 @@ err_power:
>  	return ret;
>  }
> 
> -static int twl4030_madc_remove(struct platform_device *pdev)
> +static int __exit twl4030_madc_remove(struct platform_device *pdev)
>  {
>  	struct twl4030_madc_data *madc = platform_get_drvdata(pdev);

Removing __exit_p() would be better.
I will send V2 patch.

> 
> --
> 1.7.2.5


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ