linux-kernel - Re: [PATCH] staging: android: ashmem: get_name, set_name not to hold ashmem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJsYZ5=LTon+Wq=2B08HiRKr5o2g9syhfqFVgM7JD3bS5a_tzg@mail.gmail.com>
Date:	Wed, 20 Feb 2013 17:49:41 +0530
From:	Shankar Brahadeeswaran <shankoo77@...il.com>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	Cruz Julian Bishop <cruzjbishop@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Hugh Dickins <hughd@...gle.com>,
	Konstantin Khlebnikov <khlebnikov@...nvz.org>
Subject: Re: [PATCH] staging: android: ashmem: get_name, set_name not to hold ashmem_mutex

Hi Dan,
Thanks for the feedback. I have incorporated both your review comments
and have re-tested the patch.
I'll submit the patch for approval.

Warm Regards,
Shankar


On Tue, Feb 19, 2013 at 7:08 PM, Dan Carpenter <dan.carpenter@...cle.com> wrote:
> Good job fixing the bug.  :)
>
> My one concern would be that in set_name() there is a race caused
> by dropping the lock.  It would be better to do that
> copy_from_user() first, before taking the lock.  I don't expect this
> to actually be a problem in real life.
>
> +       /*
> +        * Local variable to hold the name copied from user space
> +        * This variable is approx of size 270 bytes, not huge
> +        */
> +       char local_name[ASHMEM_NAME_LEN];
>
> These obvious comments are not needed.  We trust you do not overflow
> the stack.  ;)  Also it's checked automatically during build.
>
> Looks good generally.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/