linux-kernel - Re: [PATCH] events: always do slow path when trying to find a pmu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130220171645.GB3570@htj.dyndns.org>
Date:	Wed, 20 Feb 2013 09:16:45 -0800
From:	Tejun Heo <tj@...nel.org>
To:	Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc:	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>, linux-kernel@...r.kernel.org,
	"Kirill A . Shutemov" <kirill.shutemov@...ux.intel.com>,
	linux-next@...r.kernel.org,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH] events: always do slow path when trying to find a pmu

On Wed, Feb 20, 2013 at 07:09:36PM +0200, Andy Shevchenko wrote:
> The guilty commit is cc5b5f6 "events: convert to idr_alloc()" together with
> f49318a "idr: implement lookup hint". In our case the idr_alloc is never called, but idr_find is. The hint field is never initialized and could not be dereferenced.

Ah, right, ->hint is uninitialized at the beginning.

> The proposed fix uses the idr_slowpath call which reflects old behaviour.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> Reported-by: Kirill A. Shutemov <kirill.shutemov@...ux.intel.com>
> ---
>  kernel/events/core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/kernel/events/core.c b/kernel/events/core.c
> index 624e53f..20421ea 100644
> --- a/kernel/events/core.c
> +++ b/kernel/events/core.c
> @@ -6076,7 +6076,7 @@ struct pmu *perf_init_event(struct perf_event *event)
>  	idx = srcu_read_lock(&pmus_srcu);
>  
>  	rcu_read_lock();
> -	pmu = idr_find(&pmu_idr, event->attr.type);
> +	pmu = idr_find_slowpath(&pmu_idr, event->attr.type);

But I don't think this is the right thing to do.  I'm working on
proper fix for idr_find().  Will post soon.

Thanks!

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/