linux-kernel - Re: [PATCH] TTY: do not reset master's packet mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20130220173229.GA32279@x2.net.home>
Date:	Wed, 20 Feb 2013 18:32:29 +0100
From:	Karel Zak <kzak@...hat.com>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...uxfoundation.org, alan@...ux.intel.com,
	jirislaby@...il.com, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <mchehab@...hat.com>,
	Bryan Mason <bmason@...hat.com>
Subject: Re: [PATCH] TTY: do not reset master's packet mode

On Wed, Feb 20, 2013 at 05:40:34PM +0100, Jiri Slaby wrote:
> On 02/20/2013 02:19 PM, Karel Zak wrote:
> > On Tue, Jan 15, 2013 at 11:26:22PM +0100, Jiri Slaby wrote:
> >> Now that login from util-linux is forced to drop all references to a
> >> TTY which it wants to hangup (to reach reference count 1) we are
> >> seeing issues with telnet. When login closes its last reference to the
> >> slave PTY, it also resets packet mode on the *master* side. And we
> >> have a race here.
> > 
> > [...]
> > 
> >> By this I am resurrecting an old bug, see References. We are hitting
> >> it regularly now, i.e. with updated util-linux, ergo login.
> >>
> >> Here, I am changing a behavior introduced back in 2.1 times. It would
> >> better have a long time testing before goes upstream.
> > 
> >  It would be nice to found a quick way how to resolve this problem,
> >  because telnet+login is broken now... and for end users it seems like
> >  a regression.
> 
> Oh, the patch is in the TTY tree and I suppose it will go to 3.9-rc1
> (and to stable as we will get to same later -rc -- to have some testing).

 Cool. Thanks for feedback.

    Karel

-- 
 Karel Zak  <kzak@...hat.com>
 http://karelzak.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/