linux-kernel - Re: [PATCH 1/1] kernel/fork.c: Simplifying a snippet of code.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87hal6iv6w.fsf@xmission.com>
Date:	Wed, 20 Feb 2013 12:31:19 -0800
From:	ebiederm@...ssion.com (Eric W. Biederman)
To:	"Raphael S.Carvalho" <raphael.scarv@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Oleg Nesterov <oleg@...hat.com>,
	Al Viro <viro@...iv.linux.org.uk>,
	Srikar Dronamraju <srikar@...ux.vnet.ibm.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] kernel/fork.c: Simplifying a snippet of code.

"Raphael S.Carvalho" <raphael.scarv@...il.com> writes:

> Just sending this patch in order to simplify the code.
> However, I'm not sure if the code was written in that way due to
> specific reasons.

That doesn't look any simpler to me, and I expect you have now biased
the branch in the wrong direction.

The CLONE_THREAD is not the common case.

Eric

> Signed-off-by: Raphael S.Carvalho <raphael.scarv@...il.com>
> ---
>  kernel/fork.c |    4 +---
>  1 files changed, 1 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/fork.c b/kernel/fork.c
> index c535f33..237204d 100644
> --- a/kernel/fork.c
> +++ b/kernel/fork.c
> @@ -1341,9 +1341,7 @@ static struct task_struct *copy_process(unsigned long clone_flags,
>  	}
>  
>  	p->pid = pid_nr(pid);
> -	p->tgid = p->pid;
> -	if (clone_flags & CLONE_THREAD)
> -		p->tgid = current->tgid;
> +	p->tgid = (clone_flags & CLONE_THREAD) ? current->tgid : p->pid;
>  
>  	p->set_child_tid = (clone_flags & CLONE_CHILD_SETTID) ? child_tidptr : NULL;
>  	/*
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/