linux-kernel - Re: [PATCH 05/16] blackfin idle: delete pm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2013 22:18:17 +0100
From:	"Rafael J. Wysocki" <rjw@...k.pl>
To:	Lars-Peter Clausen <lars@...afoo.de>
Cc:	Len Brown <lenb@...nel.org>, linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org, Len Brown <len.brown@...el.com>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH 05/16] blackfin idle: delete pm_idle

On Wednesday, February 20, 2013 09:21:16 PM Lars-Peter Clausen wrote:
> On 02/20/2013 08:59 PM, Rafael J. Wysocki wrote:
> > On Wednesday, February 20, 2013 08:53:38 PM Lars-Peter Clausen wrote:
> >> On 02/20/2013 08:52 PM, Rafael J. Wysocki wrote:
> >>> On Monday, February 18, 2013 05:28:19 PM Lars-Peter Clausen wrote:
> >>>> On 02/10/2013 06:58 AM, Len Brown wrote:
> >>>>> From: Len Brown <len.brown@...el.com>
> >>>>>
> >>>>> pm_idle is dead code on blackfin.
> >>>>>
> >>>>> Signed-off-by: Len Brown <len.brown@...el.com>
> >>>>> Cc: uclinux-dist-devel@...ckfin.uclinux.org
> >>>>> ---
> >>>>>  arch/blackfin/kernel/process.c | 7 -------
> >>>>>  1 file changed, 7 deletions(-)
> >>>>>
> >>>>> diff --git a/arch/blackfin/kernel/process.c b/arch/blackfin/kernel/process.c
> >>>>> index 3e16ad9..8061426 100644
> >>>>> --- a/arch/blackfin/kernel/process.c
> >>>>> +++ b/arch/blackfin/kernel/process.c
> >>>>> @@ -39,12 +39,6 @@ int nr_l1stack_tasks;
> >>>>>  void *l1_stack_base;
> >>>>>  unsigned long l1_stack_len;
> >>>>>  
> >>>>> -/*
> >>>>> - * Powermanagement idle function, if any..
> >>>>> - */
> >>>>> -void (*pm_idle)(void) = NULL;
> >>>>> -EXPORT_SYMBOL(pm_idle);
> >>>>> -
> >>>>>  void (*pm_power_off)(void) = NULL;
> >>>>>  EXPORT_SYMBOL(pm_power_off);
> >>>>>  
> >>>>> @@ -81,7 +75,6 @@ void cpu_idle(void)
> >>>>>  {
> >>>>>  	/* endless idle loop with no priority at all */
> >>>>>  	while (1) {
> >>>>> -		void (*idle)(void) = pm_idle;
> >>>>
> >>>> Hi,
> >>>>
> >>>> This results in the following error:
> >>>>
> >>>> arch/blackfin/kernel/process.c: In function ‘cpu_idle’:
> >>>> arch/blackfin/kernel/process.c:83: error: ‘idle’ undeclared (first use in
> >>>> this function)
> >>>> arch/blackfin/kernel/process.c:83: error: (Each undeclared identifier is
> >>>> reported only once
> >>>> arch/blackfin/kernel/process.c:83: error: for each function it appears in.)
> >>>> arch/blackfin/kernel/process.c:88: error: implicit declaration of function
> >>>> ‘idle’
> >>>>
> >>>>
> >>>> This change on top of your patch, fixes it.
> >>>
> >>> Lars, I need your sign-off for the patch below.  May I add it?
> >>>
> >>> Rafael
> >>
> >> Sure, I didn't realize the patches had already been merged, otherwise I'd have
> >> sent a proper patch.
> > 
> > Please do now, if you can.  Sorry for the trouble.
> > 
> 
> I can send it tomorrow morning, it's on my machine at work.

That will be fine.

Thanks,
Rafael


-- 
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/