linux-kernel - Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 20 Feb 2013 11:26:54 +0900
From:	Tomoya MORINAGA <tomoya.rohm@...il.com>
To:	Vinod Koul <vinod.koul@...el.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interrupt context

Hi

Could you review this patch ?
8 days have passed...

thanks,
tomoya

On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@...il.com> wrote:
> pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> called from interrupt context(e.g. Uart driver "pch_uart.c").
> In fact, I saw kernel error message.
> So, GFP_ATOMIC must be used not GFP_NOIO.
>
> Signed-off-by: Tomoya MORINAGA <tomoya.rohm@...il.com>
> ---
>  drivers/dma/pch_dma.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> index 987ab5c..d5cbd44 100644
> --- a/drivers/dma/pch_dma.c
> +++ b/drivers/dma/pch_dma.c
> @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
>         dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
>
>         if (!ret) {
> -               ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> +               ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
>                 if (ret) {
>                         spin_lock(&pd_chan->lock);
>                         pd_chan->descs_allocated++;
> --
> 1.7.4.4

-- 
ROHM Co., Ltd.
tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/