linux-kernel - Re: [PATCH] posix-timer: don't call idr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.02.1302210010250.22263@ionos>
Date:	Thu, 21 Feb 2013 00:11:10 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Tejun Heo <tj@...nel.org>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Sasha Levin <sasha.levin@...cle.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] posix-timer: don't call idr_find() w/ out-of-range ID

On Wed, 20 Feb 2013, Tejun Heo wrote:

> Hello, Thomas.
> 
> On Thu, Feb 21, 2013 at 12:01:07AM +0100, Thomas Gleixner wrote:
> > idr_find() should simply return NULL, if "id < 0". Is it that hard?
> 
> It already does but w/ WARN_ON_ONCE().  The WARN_ON_ONCE() is there
> mostly as a transitional precaution.  As the previous idr_find()
> behavior was extremely weird, just in case someone was depending on
> ignoring the msb for example, it would be nice to be able to identify
> the ones which are passing in negative ids, at least for a release
> cycle or two.

No objection, but please add this to the changelog and the comment.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/