linux-kernel - Re: [PATCH] m68k/nommu: fix build when CPU is not coldfire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <512624F2.2030004@uclinux.org>
Date:	Thu, 21 Feb 2013 23:45:22 +1000
From:	Greg Ungerer <gerg@...inux.org>
To:	Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
CC:	geert@...ux-m68k.org, linux-m68k@...ts.linux-m68k.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] m68k/nommu: fix build when CPU is not coldfire

Hi Thadeu,

On 17/02/13 11:33, Thadeu Lima de Souza Cascardo wrote:
> Commit dd1cb3a7c43508c29e17836628090c0735bd3137 unified mm/init.c for both MMU
          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Its good practice to include the text title of the patch along with the
commit id.


> and non-MMU m68k platforms. However, it broke when we build a non-MMU M68K
> Classic CPU kernel.
>
> This fix builds a section that came from the MMU version only when we are
> building a MMU kernel.

Looks good thanks. I will push this into the m68knommu git tree.

Regards
Greg



> Signed-off-by: Thadeu Lima de Souza Cascardo <cascardo@...oscopio.com>
> ---
>   arch/m68k/mm/init.c |    2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/m68k/mm/init.c b/arch/m68k/mm/init.c
> index afd8106f..519aad8 100644
> --- a/arch/m68k/mm/init.c
> +++ b/arch/m68k/mm/init.c
> @@ -188,7 +188,7 @@ void __init mem_init(void)
>   		}
>   	}
>
> -#if !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)
> +#if defined(CONFIG_MMU) && !defined(CONFIG_SUN3) && !defined(CONFIG_COLDFIRE)
>   	/* insert pointer tables allocated so far into the tablelist */
>   	init_pointer_table((unsigned long)kernel_pg_dir);
>   	for (i = 0; i < PTRS_PER_PGD; i++) {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/