linux-kernel - Re: [perf patch] perf doesn't delete /tmp/perf-vdso.so.* file on exit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <loom.20130221T191341-303@post.gmane.org>
Date:	Thu, 21 Feb 2013 18:19:52 +0000 (UTC)
From:	Namhyung Kim <namhyung@...nel.org>
To:	linux-kernel@...r.kernel.org
Subject: Re: [perf patch] perf doesn't delete /tmp/perf-vdso.so.* file on exit

Markus Trippelsdorf <markus <at> trippelsdorf.de> writes:
> 
> perf top doesn't unlink /tmp/perf-vdso.so.* on exit.
> Fix this by calling vdso__exit() before exit(0).

> @@ -602,6 +603,7 @@ static void *display_thread_tui(void *arg)
>  				      &top->session->header.env);
> 
>  	exit_browser(0);
> +	vdso__exit();
>  	exit(0);
>  	return NULL;
>  }

I don't think it's enough - it doesn't cover all exit paths.
I'd suggest making it to use atexit/on_exit().

Thanks,
Namhyung



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/