linux-kernel - Re: [PATCH] Unset LANG in setlocalversion script

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <51268E25.6070104@suse.cz>
Date:	Thu, 21 Feb 2013 22:14:13 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Christophe Leroy <christophe.leroy@....fr>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org
Subject: Re: [PATCH] Unset LANG in setlocalversion script

Dne 21.2.2013 13:49, Christophe Leroy napsal(a):
> This patch allows the use of setlocalversion script regardless of the LANG
> parameter. Otherwise, the `svn info 2>/dev/null | grep '^Last Changed Rev'`
> returns nothing because for instance, in French the text 'Last Changed Rev'
> is replaced by 'Révision de la derničre modification'

Unsetting LANG might not be enough. You should unset LC_ALL and set
LC_MESSAGES=C. But - is this a problem for other commands in the script?
>From a quick look, we only parse English output of svn, so I suggest to
only set the env var for the svn command.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/