linux-kernel - Re: [PATCH v2] memcg: Add memory.pressure

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20130221235608.GH16950@blaptop>
Date:	Fri, 22 Feb 2013 08:56:08 +0900
From:	Minchan Kim <minchan@...nel.org>
To:	Anton Vorontsov <anton@...msg.org>
Cc:	Tejun Heo <tj@...nel.org>, cgroups@...r.kernel.org,
	David Rientjes <rientjes@...gle.com>,
	Pekka Enberg <penberg@...nel.org>,
	Mel Gorman <mgorman@...e.de>,
	Glauber Costa <glommer@...allels.com>,
	Michal Hocko <mhocko@...e.cz>,
	"Kirill A. Shutemov" <kirill@...temov.name>,
	Kamezawa Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Luiz Capitulino <lcapitulino@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Greg Thelen <gthelen@...gle.com>,
	Leonid Moiseichuk <leonid.moiseichuk@...ia.com>,
	KOSAKI Motohiro <kosaki.motohiro@...il.com>,
	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>,
	John Stultz <john.stultz@...aro.org>, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, linaro-kernel@...ts.linaro.org,
	patches@...aro.org, kernel-team@...roid.com
Subject: Re: [PATCH v2] memcg: Add memory.pressure_level events

Hi Anton,

On Thu, Feb 21, 2013 at 03:04:26PM -0800, Anton Vorontsov wrote:
> On Tue, Feb 19, 2013 at 04:21:28PM -0800, Tejun Heo wrote:
> > On Tue, Feb 19, 2013 at 4:17 PM, Minchan Kim <minchan@...nel.org> wrote:
> > > Should we really enable memcg for just pressure notificaion in embedded side?
> > > I didn't check the size(cgroup + memcg) and performance penalty but I don't want
> > > to add unnecessary overhead if it is possible.
> > > Do you have a plan to support it via global knob(ie, /proc/mempressure), NOT memcg?
> > 
> > That should be handled by mempressure at the root cgroup. If that adds
> > significant amount of overhead code or memory-wise, we just need to
> > fix root cgroup handling in memcg. No reason to further complicate the
> > interface which already is pretty complex.
> 
> For what it worth, I agree here. Even if we decide to make another
> interface to vmpressure (which, say, would not require memcg), then it is
> better to keep the API the same: eventfd + control file. That way,
> API/ABI-wise there will be no differnce between memcg and non-memcg
> kernels, which is cool.

I tend to agree Tejun's opinion POV maintain and I don't have a number
of memcg static/dynamic effect for embedded side so I don't want to argue now.
AFAIRC, Mel reported last year that memcg had rather no small runtime effect
and some memcg guys are trying to solve it. The memcg guy among Cced guys of
this thread could answer that more clearly.

I don't care whatever API looks like. Of course, keeping the API the same is
always good if we decide to need it. The my point is that you have a plan
to support? Why I have a question is that you said your goal is to replace
lowmemory killer but android don't have enabled CONFIG_MEMCG as you know well
so they should enable it for using just notifier? or they need another hack to
connect notifier to global thing?

What's the plan?

> 
> Thanks,
> Anton
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>

-- 
Kind regards,
Minchan Kim
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/