linux-kernel - Re: [PATCH XEN] xen: event channel arrays are xen_ulong

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1361523313.26546.109.camel@zakaz.uk.xensource.com>
Date:	Fri, 22 Feb 2013 08:55:13 +0000
From:	Ian Campbell <Ian.Campbell@...rix.com>
To:	Jan Beulich <JBeulich@...e.com>
CC:	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	"linux-arm-kernel@...ts.infradead.org" 
	<linux-arm-kernel@...ts.infradead.org>,
	"xen-devel@...ts.xen.org" <xen-devel@...ts.xen.org>,
	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"Keir (Xen.org)" <keir@....org>, "Tim (Xen.org)" <tim@....org>
Subject: Re: [PATCH XEN] xen: event channel arrays are xen_ulong_t and not
 unsigned long

On Fri, 2013-02-22 at 08:48 +0000, Jan Beulich wrote:
> >>> On 22.02.13 at 09:28, Ian Campbell <Ian.Campbell@...rix.com> wrote:
> > On Fri, 2013-02-22 at 08:12 +0000, Jan Beulich wrote:
> >> >>> On 21.02.13 at 18:16, Ian Campbell <Ian.Campbell@...rix.com> wrote:
> >> > On Tue, 2013-02-19 at 14:49 +0000, Ian Campbell wrote:
> >> >> On ARM we want these to be the same size on 32- and 64-bit.
> >> >> 
> >> >> This is an ABI change on ARM. X86 does not change.
> >> >> 
> >> >> Signed-off-by: Ian Campbell <ian.campbell@...rix.com>
> >> >> Cc: Jan Beulich <JBeulich@...e.com>
> >> >> Cc: Keir (Xen.org) <keir@....org>
> >> > 
> >> > Are you guys (un)happy with this change from the Xen & x86 side?
> >> 
> >> I don't see any problem with it.
> > 
> > I'll take this as an Acked-by if that's ok with you.
> 
> Well, I specifically didn't say "ack": I don't really mind the change,
> but I'm also not eager see it go in. Not seeing a problem with it
> doesn't really mean there's none lurking - type changes in public
> interfaces are always an at least slightly risky business.

For x86 there is no change here since:
xen/include/public/arch-x86/xen.h:typedef unsigned long xen_ulong_t;

Also the tools/include/xen-foreign checks show no change in the size of
things on x86.

On ARM the change is deliberate, if there is any fallout we can fix it.

Ian.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/