linux-kernel - Re: [PATCH v2 1/1] depmod: pass -P $CONFIG_SYMBOL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 22 Feb 2013 11:56:21 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	James Hogan <james.hogan@...tec.com>
Cc:	linux-kernel@...r.kernel.org, linux-kbuild@...r.kernel.org,
	Mike Frysinger <vapier@...too.org>,
	Yoshinori Sato <ysato@...rs.sourceforge.jp>,
	uclinux-dist-devel@...ckfin.uclinux.org
Subject: Re: [PATCH v2 1/1] depmod: pass -P $CONFIG_SYMBOL_PREFIX

On Wed, Feb 06, 2013 at 12:56:59PM +0000, James Hogan wrote:
> On architectures which have symbol prefixes, depmod emits lots of
> warnings like this:
> 
> WARNING: $module.ko needs unknown symbol $symbol
> 
> This is because depmod isn't being passed the -P <symbol_prefix>
> arguments to specify the symbol prefix to ignore. This option is
> included since the 3.13 release of module-init-tools.
> 
> Update scripts/depmod.sh to take extra arguments for the symbol prefix
> (required but may be empty), and update the main Makefile to always pass
> "$(CONFIG_SYMBOL_PREFIX)" to scripts/depmod.sh.
> 
> If the provided symbol prefix is non-empty, scripts/depmod.sh checks if
> depmod --version reports module-init-tools with a version number < 3.13
> otherwise it appends -P $SYMBOL_PREFIX to the depmod command line.
> 
> Signed-off-by: James Hogan <james.hogan@...tec.com>
> Cc: Michal Marek <mmarek@...e.cz>
> Cc: linux-kbuild@...r.kernel.org
> Cc: Mike Frysinger <vapier@...too.org>
> Cc: Yoshinori Sato <ysato@...rs.sourceforge.jp>
> Cc: uclinux-dist-devel@...ckfin.uclinux.org
> ---
> changes since v1: clean up with assistance from Mike Frysinger (thanks!)
> * always pass prefix to depmod.sh to simplify the logic
> * use printf instead of ugly echos in version check

Applied to kbuild.git#kbuild, thanks.

Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/